Skip to content

feat(i18n): expert-modal SelectItems + billing-toggle aria-labels#20

Open
abdout wants to merge 1 commit into
mainfrom
feat/i18n-pricing-sections
Open

feat(i18n): expert-modal SelectItems + billing-toggle aria-labels#20
abdout wants to merge 1 commit into
mainfrom
feat/i18n-pricing-sections

Conversation

@abdout
Copy link
Copy Markdown
Contributor

@abdout abdout commented Apr 25, 2026

Summary

  • Audit PR-7 scoped `pricing/sections/` + `expert-modal` for i18n. After investigation, the `sections/` files are dead clone artifacts (no callers); the live pricing components (`pricing-header`, `pricing-cards`, `compare-plans`, `pricing-faqs`, `enterprise-section`) are already i18n-complete. Real scope reduces to two live components.
  • Adds 17 keys to `expert.*` namespace covering project types (5), budgets (4), timelines (4), and the two billing-toggle aria-labels — Arabic translations for all.

Changes

  • `src/components/internationalization/{en,ar}.json` — `expert.{projectTypes,budgets,timelines,toggleMonthlyAria,toggleYearlyAria}`
  • `src/components/marketing/expert-modal.tsx` — replace 13 hardcoded SelectItem children with `t.expert.*` lookups
  • `src/components/marketing/pricing/billing-toggle.tsx` — replace 2 hardcoded aria-labels

Test plan

  • /ar — open expert modal (via vedio-card CTA) → all dropdowns translate
  • /ar/pricing — billing toggle aria-labels read in Arabic for screen readers
  • /en/pricing — visually unchanged
  • `pnpm tsc --noEmit` — no new errors

Out of scope

  • Pricing dead-code cleanup (delete `sections/*`, `pricing-faq.tsx`, `newsletter-form.tsx`)
  • Class 1 dead imports in pricing components — separate PR
  • Service component alt text + chatbot button titles + mode-switcher — PR-7b

Closes #19

🤖 Generated with Claude Code

Adds 17 keys under expert.* (projectTypes, budgets, timelines for the
SelectItems that were hardcoded in English; toggleMonthlyAria and
toggleYearlyAria for the billing toggle) and wires them up.

PR-7 audit scope was revised after investigation: most flagged
"pricing/sections/*" files are dead clone artifacts (never rendered).
The live pricing page (pricing-header, pricing-cards, compare-plans,
pricing-faqs, enterprise-section) is already i18n-complete. Only
expert-modal and billing-toggle remained.

Closes #19

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marketing Ready Ready Preview, Comment Apr 25, 2026 0:17am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(i18n): translate expert-modal SelectItems + billing-toggle aria-labels

1 participant